Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organized visualizers to hopefully allow easier implementations of ne… #77

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Organized visualizers to hopefully allow easier implementations of ne… #77

merged 3 commits into from
Sep 17, 2024

Conversation

brennanfreeze
Copy link
Member

@brennanfreeze brennanfreeze commented Sep 16, 2024 •
edited
Loading

…w ones

Pull Request

Description

Please include a summary of the changes and the motivation behind them. If applicable, link to any related issues.

Type of Change

Please check the type of change your PR introduces:

  • Bugfix
  • New feature
  • Enhancement
  • Documentation
  • [ X] Refactoring
  • Other (please specify):

Checklist

  • [ X] I have read the contributing guidelines.
  • [ X] I have added tests that prove my fix is effective or that my feature works.
  • I have updated the documentation accordingly.
  • [X ] I ran black formatter on the codebase. (CI/CD will fail if neglected)
  • [X ] My code follows the project's coding style guidelines.

Related Issues

  • Closes # (issue number)
  • Related to # (issue number)

Screenshots (if applicable)

If your change includes visual updates, please include screenshots to demonstrate the changes.

Additional Notes

Add any additional notes or comments here. For example, describe any known issues or limitations.

parisosuch-dev
parisosuch-dev approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@parisosuch-dev parisosuch-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I saw a function that needed type hints for the parameters but we can go back and add those.

@parisosuch-dev parisosuch-dev merged commit 8c28c2a into main Sep 17, 2024
2 checks passed
@parisosuch-dev parisosuch-dev deleted the bfreeze-viualize-cleanup branch September 17, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisosuch-dev parisosuch-dev parisosuch-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brennanfreeze @parisosuch-dev